Add Float.toFixed and friends
#142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
force-pushed
the
add-float-tofixed-n-friends
branch
from
10047e7 to
a468b75
Compare
|
I'm not convinced this is the way to go. Because the behavior in native will differ from the JS one in some cases, it kind of defeats one of the main purpose of server-reason-react (render same HTML in server with OCaml and client with Melange). I think it's better to keep current @davesnx feel free to reopen if anything's recoverable :) |
|
Currently the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously based on
asset-prefix(#140).Adds some functions to
Js.Float.