Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the right extension syntax on promise.js #194

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Use the right extension syntax on promise.js #194

merged 1 commit into from
Dec 10, 2024

Conversation

pedrobslisboa
Copy link
Collaborator

Description

The usage of %mel.raw on promise.js breaks the js code.
This bug was added here: ea16c10

@pedrobslisboa pedrobslisboa added the bug Something isn't working label Dec 10, 2024
@pedrobslisboa pedrobslisboa self-assigned this Dec 10, 2024
@davesnx davesnx merged commit 44f532a into main Dec 10, 2024
2 checks passed
@davesnx davesnx deleted the fix/promise-mel-raw branch December 10, 2024 18:24
davesnx added a commit that referenced this pull request Dec 11, 2024
@davesnx
Merge branch 'main' of github.com:ml-in-barcelona/server-reason-react…
7893d00 
… into Create-client-components-ref-map

* 'main' of github.com:ml-in-barcelona/server-reason-react:
  Use the right extension syntax on promise.js (#194)
pedrobslisboa added a commit that referenced this pull request Dec 11, 2024
@pedrobslisboa
Merge remote-tracking branch 'origin/main' into feat/platform-on-expr…
34fe287 
…essions

* origin/main:
  Use the right extension syntax on promise.js (#194)
  Battle test RSC with Suspense + client components (#190)
  Move ppx transformation to function body (not last expression) (#192)
  fix: format missing mel.raw
  chore: update reason to 3.14
  Update README.md
pedrobslisboa added a commit that referenced this pull request Dec 11, 2024
@pedrobslisboa
Merge remote-tracking branch 'origin/main' into feat/platform-on-expr…
e81cd90 
…essions

* origin/main:
  Use the right extension syntax on promise.js (#194)
  Battle test RSC with Suspense + client components (#190)
  Move ppx transformation to function body (not last expression) (#192)
  fix: format missing mel.raw
  chore: update reason to 3.14
  Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davesnx davesnx Awaiting requested review from davesnx

Assignees

@pedrobslisboa pedrobslisboa

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedrobslisboa @davesnx