Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text Reading] Set _JAVA_OPTIONS to min. RAM requirements #507

Merged
merged 5 commits into from
Sep 28, 2023
Merged

[Text Reading] Set _JAVA_OPTIONS to min. RAM requirements #507

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3dc383
Set min. expectations for _JAVA_OPTIONS
myedibleenso Sep 26, 2023
dc86950
6GB -> 10GB :(
myedibleenso Sep 26, 2023
35673c5
Merge branch 'main' into ghp/java-opts-docker
myedibleenso Sep 27, 2023
600e258
Removed contradictory comment
myedibleenso Sep 27, 2023
14664b8
Merge branch 'main' into ghp/java-opts-docker
enoriega Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions skema/text_reading/scala/webapp/docker.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,15 @@ Docker / version := tag
// set our version based on our env variable
dockerEnvVars ++= Map(
"APP_VERSION" -> scala.util.Properties.envOrElse("APP_VERSION", "???"),
"APPLICATION_SECRET" -> "this-is-not-a-secure-key-please-change-me"
"APPLICATION_SECRET" -> "this-is-not-a-secure-key-please-change-me",
// NOTE: the expected min. RAM requirements
// FIXME: reduce RAM consumption $\le 8GB$
"_JAVA_OPTIONS" -> "-Xmx10g -Xms10g -Dfile.encoding=UTF-8"
)
dockerAdditionalPermissions += (DockerChmodType.UserGroupPlusExecute, app)
dockerChmodType := DockerChmodType.UserGroupWriteExecute
// dockerCmd := Seq(s"-Dhttp.port=$port")
dockerEntrypoint := Seq(app)
// This is now delegated to skema-webapp.env.
// dockerEnvVars := Map(
// "_JAVA_OPTIONS" -> "-Xmx16g -Xms16g -Dfile.encoding=UTF-8"
// )
dockerPermissionStrategy := DockerPermissionStrategy.MultiStage
dockerUpdateLatest := true

Expand Down