-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code2fn] Various bug fixes and documentation updates #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
lang/Fortran
Used for work related to Fortran (ex. frontend support)
labels
Apr 9, 2024
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Apr 9, 2024
…/skema into vraymond/m12_documentation
…/skema into vraymond/m12_documentation
skema/program_analysis/CAST/fortran/tests/test_compound_conditional_cast_fortran.py
Outdated
Show resolved
Hide resolved
skema/program_analysis/model_coverage_report/model_coverage_report.py
Outdated
Show resolved
Hide resolved
vincentraymond-ua
requested review from
myedibleenso
and removed request for
titomeister
April 19, 2024 15:01
myedibleenso
requested changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, @vincentraymond-ua . Just one small issue with skema/utils
that went unnoticed/predated this PR.
myedibleenso
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @vincentraymond-ua !
github-actions bot
added a commit
that referenced
this pull request
Apr 19, 2024
## Summary of Changes - Adds unit testing for Fortran compound-conditional - Adds missing files for consumer mode model coverage reports - Fixes circular dependency issue between model coverage reports and img2mml - Pins code2fn related libraries in pyproject.toml - Pins all tree-sitter grammar versions to prevent a breaking change in the future. ### Related issues Resolves #663 Resolves #876 482b768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI
continuous integration and automated workflows
lang/Fortran
Used for work related to Fortran (ex. frontend support)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related issues
Resolves #663
Resolves #876