Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code2fn] Various bug fixes and documentation updates #878

Merged
merged 32 commits into from
Apr 19, 2024

Conversation

vincentraymond-ua
Copy link
Contributor

@vincentraymond-ua vincentraymond-ua commented Apr 9, 2024

Summary of Changes

  • Adds unit testing for Fortran compound-conditional
  • Adds missing files for consumer mode model coverage reports
  • Fixes circular dependency issue between model coverage reports and img2mml
  • Pins code2fn related libraries in pyproject.toml
  • Pins all tree-sitter grammar versions to prevent a breaking change in the future.

Related issues

Resolves #663
Resolves #876

@github-actions github-actions bot added documentation Improvements or additions to documentation lang/Fortran Used for work related to Fortran (ex. frontend support) labels Apr 9, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Apr 9, 2024
@github-actions github-actions bot added the CI continuous integration and automated workflows label Apr 10, 2024
@vincentraymond-ua vincentraymond-ua marked this pull request as ready for review April 12, 2024 15:01
pyproject.toml Outdated Show resolved Hide resolved
@vincentraymond-ua vincentraymond-ua requested review from myedibleenso and removed request for titomeister April 19, 2024 15:01
Copy link
Collaborator

@myedibleenso myedibleenso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, @vincentraymond-ua . Just one small issue with skema/utils that went unnoticed/predated this PR.

skema/utils/change_dir_back.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@myedibleenso myedibleenso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vincentraymond-ua !

@myedibleenso myedibleenso merged commit 482b768 into main Apr 19, 2024
7 checks passed
@myedibleenso myedibleenso deleted the vraymond/m12_documentation branch April 19, 2024 18:20
github-actions bot added a commit that referenced this pull request Apr 19, 2024
## Summary of Changes
- Adds unit testing for Fortran compound-conditional
- Adds missing files for consumer mode model coverage reports
- Fixes circular dependency issue between model coverage reports and
img2mml
- Pins code2fn related libraries in pyproject.toml
- Pins all tree-sitter grammar versions to prevent a breaking change in
the future.

### Related issues

Resolves #663
Resolves #876 482b768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration and automated workflows lang/Fortran Used for work related to Fortran (ex. frontend support)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fortran] Tests for compound conditionals [code2fn] M12 Updates to Code Model Coverage Tracker
2 participants