Define kfp as extra and update error messages (#361)

ml6team · Aug 17, 2023 · 9a022aa · 9a022aa
1 parent e580189
commit 9a022aa
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 91 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -52,14 +52,13 @@ gcsfs = { version = ">= 2023.4.0", optional = true }
 s3fs = { version = ">= 2023.4.0", optional = true }
 adlfs = { version = ">= 2023.4.0", optional = true }
 kfp = { version = ">= 1.8.19, < 2", optional = true }
-kubernetes = { version = ">= 18.20.0", optional = true }
 pandas = { version = ">= 1.3.5", optional = true }
 
 [tool.poetry.extras]
 aws = ["fsspec", "s3fs"]
 azure = ["fsspec", "adlfs"]
 gcp = ["fsspec", "gcsfs"]
-pipelines = ["kfp", "kubernetes"]
+kfp = ["kfp"]
 
 [tool.poetry.group.test.dependencies]
 pre-commit = "^3.1.1"

diff --git a/src/fondant/compiler.py b/src/fondant/compiler.py
@@ -226,7 +226,7 @@ def _resolve_imports(self):
             self.kfp = kfp
         except ImportError:
             msg = """You need to install kfp to use the Kubeflow compiler,\n
-                     you can install it with `pip install --extras pipelines`"""
+                     you can install it with `pip install fondant[kfp]`"""
             raise ImportError(
                 msg,
             )

diff --git a/src/fondant/import_utils.py b/src/fondant/import_utils.py
diff --git a/src/fondant/runner.py b/src/fondant/runner.py
@@ -48,7 +48,7 @@ def _resolve_imports(self):
             self.kfp = kfp
         except ImportError:
             msg = """You need to install kfp to use the Kubeflow compiler,\n
-                     you can install it with `pip install --extras pipelines`"""
+                     you can install it with `pip install fondant[kfp]`"""
             raise ImportError(
                 msg,
             )

diff --git a/tests/test_import_utils.py b/tests/test_import_utils.py