Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building a custom component with fondant build, it requests to install docker #891

Closed
jBontinck opened this issue Mar 6, 2024 · 2 comments · Fixed by #893
Closed

Comments

@jBontinck
Copy link

I am starting from a clean setup with pip install fondant + I followed the instructions to install docker desktop.
I made an easy custom DaskLoadComponent and wanted to build it with fondant build . -t v1

I receive following message:
You need to install docker to use the fondant build command, you can install it with pip install fondant[docker]

I would expect that I don't need additional libraries given

  • I installed fondant already (implicitly all requirements)
  • I installed docker Desktop

I can solve this by following the feedback in the message, but is not what I expected

@jBontinck
Copy link
Author

jBontinck commented Mar 6, 2024

Coming back to this:
When executing the command pip install fondant[docker] i get following message zsh: no matches found: fondant[docker]

solved with pip install docker

@mrchtr
Copy link
Contributor

mrchtr commented Mar 6, 2024

@jBontinck thanks for the feedback. Looks like your shell is not interpreting the command correctly. For zsh pip install "fondant[docker]" should work. We should consider updating the log message here.

For the case you want to install all extra requirements you could use pip install "fondant[all]", but this will install a lot of things that you probably don't need right now.

It looks like we should revisit the dependencies and extra groups.

@RobbeSneyders RobbeSneyders linked a pull request Mar 6, 2024 that will close this issue
RobbeSneyders pushed a commit that referenced this issue Mar 6, 2024
Fixes:
- #891

 Fixes (maybe needs more work):
- #877
@github-project-automation github-project-automation bot moved this from Backlog to Done in Fondant development Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants