Refactor stable diffusion pipeline [part 1] #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
March 24, 2023 14:35
There was a problem hiding this comment.
Left a few comments. Looks good to me overall, the components seem much neater and compact with express compared to the previous implementation 😃
General comments:
- Only delete the components that are replaced and keep the old ones as reference. Also keep the docs explaining what the components do (you can modify them as needed)
- Make sure the requirements are fixed for all components
- Change the base image for all docker images that use GPU/Torch to one of the official pytorch images
I think we should also add the folders that are been changed to the pre-commit configs to lint them. See an example on how this is done here:
https://github.com/ml6team/express/pull/6/files
For now, you can point to every individual component that you modify and then later on we can change to point to pipelines/finetune-stable-diffusion
examples/pipelines/finetune_stable_diffusion/components/clip_downloader_component/Dockerfile
Outdated
Show resolved
Hide resolved
examples/pipelines/finetune_stable_diffusion/components/clip_retrieval_component/README.MD
Outdated
Show resolved
Hide resolved
...s/finetune_stable_diffusion/components/clip_retrieval_component/src/utils/embedding_utils.py
Outdated
Show resolved
Hide resolved
examples/pipelines/finetune_stable_diffusion/components/dataset_loader_component/README.MD
Show resolved
Hide resolved
examples/pipelines/finetune_stable_diffusion/components/dataset_loader_component/src/main.py
Outdated
Show resolved
Hide resolved
examples/pipelines/finetune_stable_diffusion/components/embedding_component/Dockerfile
Outdated
Show resolved
Hide resolved
examples/pipelines/finetune_stable_diffusion/config/components_config.py
Outdated
Show resolved
Hide resolved
examples/pipelines/finetune_stable_diffusion/components/dataset_loader_component/src/main.py
Outdated
Show resolved
Hide resolved
examples/pipelines/finetune_stable_diffusion/components/embedding_component/src/main.py
Show resolved
Hide resolved
examples/pipelines/finetune_stable_diffusion/components/image_filter_component/Dockerfile
Outdated
Show resolved
Hide resolved
examples/pipelines/finetune_stable_diffusion/components/image_filter_component/requirements.txt
Outdated
Show resolved
Hide resolved
|
|
||
| from kfp import components as comp | ||
| from kfp import dsl | ||
|
|
NielsRogge
changed the title
| @@ -1,14 +1,31 @@ | |||
| FROM europe-west1-docker.pkg.dev/storied-landing-366912/storied-landing-366912-default-repository/mlpipelines/kubeflow/components/base_component:latest | |||
| FROM --platform=linux/amd64 python:3.8-slim | |||
There was a problem hiding this comment.
Can we remove --platform=linux/amd64 and only have it as a flag in the bash script?
| @@ -1,58 +1,29 @@ | |||
| name: clip_retrieval_component | |||
There was a problem hiding this comment.
Can we remove all clip retrieval related stuff from this PR?
| @@ -0,0 +1,29 @@ | |||
| FROM --platform=linux/amd64 pytorch/pytorch:2.0.0-cuda11.7-cudnn8-runtime | |||
There was a problem hiding this comment.
Same comment as above
|
|
||
|
|
||
| @dataclass | ||
| class ClipRetrievalConfig: |
There was a problem hiding this comment.
Not needed if we remove clip retrieval from this PR
PhilippeMoussalli
approved these changes
Apr 4, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Refactor stable diffusion pipeline [part 1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the first 3 components of the Stable Diffusion pipeline by leveraging Express.
The components are: