Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ruff on components #209

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Run ruff on components #209

merged 1 commit into from
Jun 15, 2023

Conversation

RobbeSneyders
Copy link
Member

No description provided.

@RobbeSneyders RobbeSneyders marked this pull request as ready for review June 14, 2023 21:04
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robbe!

Question: seems like you use # ruff: noqa on licensed files? is that a general best practice?

@RobbeSneyders
Copy link
Member Author

Since we copied them from a different source, I would leave them as is and not make any changes. This is also clearest to define which license is appropriate.

@RobbeSneyders RobbeSneyders merged commit e2f1d2c into main Jun 15, 2023
@RobbeSneyders RobbeSneyders deleted the feature/ruff-components branch June 15, 2023 08:48
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants