[DataComp] Add image resolution filtering component #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsRogge
changed the title
NielsRogge
force-pushed
the
add_image_resolution
branch
2 times, most recently
from
29f93a0
to
22fe6ae
Compare
|
FYI, instead of using a symlink, you can also just add a path to the top components directory directly. |
NielsRogge
force-pushed
the
add_image_resolution
branch
from
f5d532d
to
cb6d4bf
Compare
|
@RobbeSneyders working now, had to update the requirements.txt to the latest commit as otherwise the Docker image wasn't updated. Feel free to approve |
There was a problem hiding this comment.
Thanks @NielsRogge!
Can you rebase on main? That will be needed to address one of my comments and will update the CI to run the latest version (I think I see some Ruff issues which are now checked on main).
examples/pipelines/datacomp/components/filter_text_complexity/requirements.txt
Outdated
Show resolved
Hide resolved
NielsRogge
force-pushed
the
add_image_resolution
branch
from
ab5f66b
to
34f5e69
Compare
NielsRogge
force-pushed
the
add_image_resolution
branch
from
ea2e76c
to
b8165f8
Compare
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
This PR adds an image resolution filtering component to the DataComp pipeline. I had to use a symlink in order to build a Docker image and use the local runner. --------- Co-authored-by: Niels Rogge <nielsrogge@nielss-mbp.home>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an image resolution filtering component to the DataComp pipeline.
I had to use a symlink in order to build a Docker image and use the local runner.