Always pull images in local runner #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeMoussalli
approved these changes
Jul 6, 2023
RobbeSneyders
force-pushed
the
feature/pull-always
branch
from
e4f1b2c
to
4a46c39
Compare
|
Yeah, I forgot to remove a change I made to make sure the tests fail in the right scenario 😛 |
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Fixes #259 This PR: - Instructs the local runner to always pull images. This makes sure that moving tags like `dev` or `latest` are up to date before running the pipeline. As far as I can tell from my testing, this doesn't cause a noticeable delay when the image was not updated. - Adds the pipeline name to the docker compose yaml and removes orphan containers. Containers are namespaced by the pipeline name, which defaults to the cwd if not specified. So I set the name explicitly so we don't accidentally remove containers from another pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
This PR:
devorlatestare up to date before running the pipeline. As far as I can tell from my testing, this doesn't cause a noticeable delay when the image was not updated.