Make components cloud agnostic #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeMoussalli
changed the title
components/caption_images/Dockerfile
Outdated
| @@ -12,7 +12,7 @@ RUN pip3 install --no-cache-dir -r requirements.txt | |||
| # Install Fondant | |||
| # This is split from other requirements to leverage caching | |||
| ARG FONDANT_VERSION=main | |||
| RUN pip3 install git+https://github.com/ml6team/fondant@${FONDANT_VERSION} | |||
| RUN pip3 install git+https://github.com/ml6team/fondant@${FONDANT_VERSION}#egg=fondant[aws, azure, gcp] | |||
There was a problem hiding this comment.
Thanks @PhilippeMoussalli
In the pip documentation (example 7), they use the following format:
pip install fondant[aws,azure,gcp] @ git+https://github.com/ml6team/fondant@${FONDANT_VERSION}
Which I think is a bit more readable and more future-proof, as eggs have been deprecated as far as I'm aware.
There was a problem hiding this comment.
oh good to know. I was not aware. I'll change them
PhilippeMoussalli
force-pushed
the
make-components-cloud-agnostic
branch
from
e622420
to
6e30a19
Compare
RobbeSneyders
approved these changes
Jul 10, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
fixes #210 Pyarrow was also removed from many of the components' requirements since it is a Fondant dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #210
Pyarrow was also removed from many of the components' requirements since it is a Fondant dependency