[LLM pipeline] Update text normalization component #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @mrchtr!
Changes to the component look good. Left some comments on the testing strategy.
There was a problem hiding this comment.
Thanks @mrchtr!
For the tests, I would go for option 1. It is simple and readable. I don't think the limited value provided by the abstractions warrants the extra complexity / "magic".
Alright. I have reduced the code to option 1. |
This was referenced Aug 17, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Add minor improvements to the text normalization component. Mainly based on the work of [Penedo et al ](https://arxiv.org/pdf/2306.01116.pdf) Quality can be improved by removing specific patterns in single lines: > We analyse documents line-by-line, and discard or edit the lines based on the following rules: • If it is mainly composed of uppercase characters (discard); • If it is only composed of numerical characters (discard); • If it is a counter (e.g. 3 likes) (discard); • If it only contains one word (discard);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add minor improvements to the text normalization component. Mainly based on the work of Penedo et al
Quality can be improved by removing specific patterns in single lines: