Add kfp constraint #341
Merged
Add kfp constraint #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyproject.toml
Outdated
| @@ -51,7 +51,7 @@ fsspec = { version = ">= 2023.4.0", optional = true} | |||
| gcsfs = { version = ">= 2023.4.0", optional = true } | |||
| s3fs = { version = ">= 2023.4.0", optional = true } | |||
| adlfs = { version = ">= 2023.4.0", optional = true } | |||
| kfp = { version = ">= 1.8.19", optional = true } | |||
| kfp = { version = ">= 1.8.19, <= 1.8.22", optional = true } | |||
There was a problem hiding this comment.
Suggested change
| kfp = { version = ">= 1.8.19, <= 1.8.22", optional = true } | |
| kfp = { version = ">= 1.8.19, < 2", optional = true } |
Can we put the upper-bound at the major version instead?
RobbeSneyders
approved these changes
Aug 8, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Add constrain to KFP version to avoid downloading latest by default (v2) which has a different API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constrain to KFP version to avoid downloading latest by default (v2) which has a different API