Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest schema and move test manifests to files #38

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

RobbeSneyders
Copy link
Member

This PR includes 3 small changes:

  • Add run_id and component_id as required metadata to the manifest schema
  • Move test manifest to files similar to the component specs
  • Leverage relative files in tests so they can be run from different working directories

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding

@RobbeSneyders RobbeSneyders force-pushed the feature/manifest-fixtures branch from 92da17c to b5ab7a5 Compare April 25, 2023 10:19
@RobbeSneyders RobbeSneyders merged commit f6312d2 into main Apr 25, 2023
@RobbeSneyders RobbeSneyders deleted the feature/manifest-fixtures branch May 15, 2023 16:29
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
This PR includes 3 small changes:
- Add `run_id` and `component_id` as required metadata to the manifest
schema
- Move test manifest to files similar to the component specs
- Leverage relative files in tests so they can be run from different
working directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants