Move container registry to DockerHub #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested a pipeline both locally and on KfP. Both work with the new registry 🎉 |
|
Yes, the fondant namespace is taken unfortunately. I will document this in the issue with some more info. |
mrchtr
reviewed
Oct 12, 2023
examples/pipelines/commoncrawl/components/extract_images_from_warc/fondant_component.yaml
Outdated
Show resolved
Hide resolved
examples/pipelines/commoncrawl/components/read_warc_paths/fondant_component.yaml
Outdated
Show resolved
Hide resolved
| @@ -1,6 +1,6 @@ | |||
| name: Clean captions | |||
| description: Component that filters out bad captions (Empty captions, Captions with weird characters, Captions that are dates) | |||
| image: ghcr.io/ml6team/clean_captions:50f3a97878ac81670ebe624039ff0fcec0542e4f | |||
| image: fndnt/clean_captions:50f3a97878ac81670ebe624039ff0fcec0542e4f | |||
There was a problem hiding this comment.
This one I can't see on docker hub. I think the example pipeline images are not pushed to docker hub?
There was a problem hiding this comment.
No, they are not built automatically. But the updated build script will push them there for you. So it's the same flow as before.
mrchtr
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495
This PR moves everything to use DockerHub as our container registry instead of Github container registry. This is necessary to support managed pipeline services such as Vertex AI and Sagemaker.
As an improvement, the README of the component is now pushed as well. Example.
The "fondant" organization is unfortunately taken on DockerHub, and we can only request a transfer if we hold a US trademark on the name. Maybe something for the future. For now, I went with "fndnt".