Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network argument to vertex runner #537

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Add network argument to vertex runner #537

merged 2 commits into from
Oct 19, 2023

Conversation

RobbeSneyders
Copy link
Member

This is needed to access private IPs from Vertex pipelines (eg. a private Weaviate endpoint).

PhilippeMoussalli
PhilippeMoussalli approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robbe! :)

There is one CLI test that is failing though (test_vertex_run()). I think you need to ad
network=None at the argparse level

@RobbeSneyders RobbeSneyders merged commit f8f4946 into main Oct 19, 2023
3 of 4 checks passed
@RobbeSneyders RobbeSneyders deleted the feature/vertex-network branch October 19, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeMoussalli PhilippeMoussalli PhilippeMoussalli approved these changes

@mrchtr mrchtr Awaiting requested review from mrchtr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbeSneyders @PhilippeMoussalli