-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide unpacked keyword arguments to component.transform
method
#74
Conversation
@@ -1,3 +1,3 @@ | |||
git+https://github.com/ml6team/fondant.git@d697be951fa33faa0baa3625cf3cb04d6800834a | |||
git+https://github.com/ml6team/fondant.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we squash merge, any commit hash part of a PR will actually not become part of main
, so it's not ideal to use them as a reference.
I think we should always keep these examples in line with main, so I would propose to unfreeze the fondant version in their requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those are mainly used for testing the functionality of your branch code. Right now the workflow is a bit annoying to do so: you have to push your code and then reference the hash so that the component can rebuild with the latest version. Wondering if there isn't a better way to do. @NielsRogge any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we 'actually open source', the examples on main should always work though. For components to share, the version can still be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes for now we probably need to include the commit hash when trying out new functionality, but when merging a PR it should always be updated to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving!
4c55907
to
96f375f
Compare
Note that ideally also the simple pipeline gets updated and tested: fondant/examples/pipelines/simple_pipeline/components/image_filtering/src/main.py Line 21 in 1ac0fa0
Cause we had updates to the Fondant code base in the past which turned out to need fixes to run the pipeline successfully on KubeFlow |
Small follow-up to #74 to update the simple pipeline components.
Small follow-up to #74 to update the simple pipeline components.
Fixes #67