Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing index Weaviate #790

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Enable testing index Weaviate #790

merged 2 commits into from
Jan 17, 2024

Conversation

PhilippeMoussalli
Copy link
Contributor

PR that enables testing the weaviate indexing component

Leverage the embedded weaviate component to setup the client and bypass the docker-compose setup

https://weaviate.io/developers/weaviate/installation/embedded


def test_index_weaviate_component(monkeypatch):
client = weaviate.Client(embedded_options=EmbeddedOptions())
monkeypatch.setattr("weaviate.Client", lambda *args, **kwargs: client)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? I didn't need this in the retrieval component test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the fact that we have access to a local URL, adjusted!

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobbeSneyders RobbeSneyders merged commit 48fbbd4 into main Jan 17, 2024
9 checks passed
@RobbeSneyders RobbeSneyders deleted the enable-testing-weaviate branch January 17, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants