-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/kfp support for lightweight components #803
Feature/kfp support for lightweight components #803
Conversation
FYI the pipeline I ran on vertex:
|
@@ -318,10 +318,6 @@ def default_arguments(self) -> t.Dict[str, Argument]: | |||
), | |||
} | |||
|
|||
@property | |||
def kubeflow_specification(self) -> "KubeflowComponentSpec": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm contemplating removing the KubeflowComponentSpec
from the component_spec.py and integrating it more in the compiler (the only place where it is used)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Geroges!
Are the ToDos still to be tackled in this PR?
@@ -318,10 +318,6 @@ def default_arguments(self) -> t.Dict[str, Argument]: | |||
), | |||
} | |||
|
|||
@property | |||
def kubeflow_specification(self) -> "KubeflowComponentSpec": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please
Yes I will do them |
dca8072
to
94b47ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Georges!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Tested successfully on vertex
TODO: