Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable write components to cache #814

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

PhilippeMoussalli
Copy link
Contributor

Fixes #813

Copy link
Collaborator

@GeorgesLorre GeorgesLorre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough

@RobbeSneyders
Copy link
Member

As discussed during standup, not sure if it makes sense to create a manifest for a write component, since it should not output a dataset.

I would also assume that the manifest it produces, points to a non-existing index. Since the index reference in the manifest is updated, but the index is not actually written.

@PhilippeMoussalli
Copy link
Contributor Author

As discussed during standup, not sure if it makes sense to create a manifest for a write component, since it should not output a dataset.

I would also assume that the manifest it produces, points to a non-existing index. Since the index reference in the manifest is updated, but the index is not actually written.

Makes sense, changed the approach. For read/transform components we write the cache file with reference to the cached manifest path, for write components we simply write the same file but with an empty string (no reference) since there is no written manifest. The cache estimation still occurs based on the cache key value

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PhilippeMoussalli PhilippeMoussalli merged commit 4400963 into main Jan 30, 2024
11 checks passed
@PhilippeMoussalli PhilippeMoussalli deleted the enable-write-components-to-cache branch January 30, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable caching for write components
3 participants