Simplify component naming #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgesLorre
requested review from
mrchtr,
RobbeSneyders and
PhilippeMoussalli
GeorgesLorre
commented
Jan 25, 2024
| @@ -101,7 +101,7 @@ def __init__( | |||
| tags: t.Optional[t.List[str]] = None, | |||
| ): | |||
| spec_dict: t.Dict[str, t.Any] = { | |||
| "name": name, | |||
| "name": self.sanitized_component_name(name), | |||
There was a problem hiding this comment.
This should be the only place where the incoming name is cleaned and stored
src/fondant/pipeline/pipeline.py
Outdated
| @@ -305,6 +300,10 @@ def _get_registry_path(name: str) -> Path: | |||
| raise ValueError(msg) | |||
| return component_dir | |||
|
|
|||
| @property | |||
| def component_id(self) -> str: | |||
There was a problem hiding this comment.
Is there a reason to call this id here instead of name?
There was a problem hiding this comment.
I'll update it
GeorgesLorre
force-pushed
the
fix/inconsistent-component-naming
branch
from
ec136ff
to
69b3c5e
Compare
mrchtr
approved these changes
Jan 26, 2024
| @@ -353,48 +354,55 @@ def from_fondant_component_spec( | |||
| }, | |||
| } | |||
|
|
|||
| cleaned_component_name = fondant_component.sanitized_component_name | |||
|
|
|||
| kfp_safe_name = ( | |||
| }, | ||
| }, | ||
| }, | ||
| "inputDefinitions": input_definitions, | ||
| }, | ||
| "schemaVersion": "2.1.0", | ||
| "sdkVersion": "kfp-2.0.1", | ||
| "sdkVersion": "kfp-2.6.0", |
There was a problem hiding this comment.
Any side effects by increasing the version?
There was a problem hiding this comment.
No, now it is in line with the KFP version we use now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the inconsistent folder names between runs (cached vs non-cached) and cleans up the different component/folder naming logic we have.