Simplify component init interface #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeMoussalli
requested review from
RobbeSneyders,
mrchtr and
GeorgesLorre
and removed request for
RobbeSneyders and
mrchtr
PhilippeMoussalli
force-pushed
the
simplify_component_init_interface
branch
2 times, most recently
from
a346a3d
to
7ba0ad1
Compare
PhilippeMoussalli
force-pushed
the
simplify_component_init_interface
branch
from
7ba0ad1
to
5db72a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need to having to define
**kwargswhen the user defines the component__init__function. This was needed before to pass the theproducesandconsumesto some read/write components without the user having to explicitly define them. This was resolved by removing those two arguments from the component signature.Tested on a pipeline with load/write components.