Make unique index sorted #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgesLorre
approved these changes
Feb 19, 2024
mrchtr
reviewed
Feb 19, 2024
We've discussed a couple of times already to create better base components, this could indeed be part of that. Seems like we only have an issue for a base inference component (#565), but would be useful for load and write components as well. This is just a quick fix though, would take that up as a separate effort.
Let's add a test when we move this into a generic load component. Opened an issue for it: #860 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unique index we create is not sorted, while I believe this was originally the goal. Ran into some issues merging large dataframes and this was one of them.