Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run ruff on new manifest tests #86

Merged
merged 1 commit into from
May 8, 2023
Merged

Run ruff on new manifest tests #86

merged 1 commit into from
May 8, 2023

Conversation

RobbeSneyders
Copy link
Member

Pipeline on main was failing after merging #80 en #83 separately.

@RobbeSneyders RobbeSneyders requested a review from GeorgesLorre May 8, 2023 10:15
PhilippeMoussalli
PhilippeMoussalli approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobbeSneyders RobbeSneyders merged commit 0213bfc into main May 8, 2023
@RobbeSneyders RobbeSneyders deleted the bugfix/manifest-test-ruff branch May 15, 2023 16:29
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
@RobbeSneyders
Run ruff on new manifest tests (#86)
7ae5436 
Pipeline on main was failing after merging #80 en #83 separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeMoussalli PhilippeMoussalli PhilippeMoussalli approved these changes

@GeorgesLorre GeorgesLorre Awaiting requested review from GeorgesLorre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbeSneyders @PhilippeMoussalli