Change dask_client to general setup method #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
commented
Feb 19, 2024
Comment on lines
-458
to
-462
| with mock.patch.object(MyPandasComponent, "__init__", init), mock.patch.object( | ||
| MyPandasComponent, | ||
| "transform", | ||
| transform, | ||
| ): |
There was a problem hiding this comment.
This was giving issues with recursion when pickling. I couldn't completely figure out the cause and how to fix it.
| init.mock.assert_called_once() | ||
| assert transform.mock.call_count == N_PARTITIONS | ||
| executor.execute(MyPandasComponent) | ||
| assert init_called == 1 |
There was a problem hiding this comment.
We cannot take the same approach for the transform method, since it's executed across Dask workers. Couldn't figure out how to make this work, so dropped the assertion for the transform method for now.
mrchtr
reviewed
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
dask_clientmethod introduced in #852 into a generalsetupmethod.This method differs from
__init__in that it allows users to return a state, which is passed into theteardownmethod by Fondant. This is necessary since the Dask client is not pickleable, and setting it as an instance attribute leads to issues when executing thetransformmethod across processes (as is the case in thePandasTransformComponent).