Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add struct to types #879

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Add struct to types #879

merged 4 commits into from
Feb 28, 2024

Conversation

PhilippeMoussalli
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli commented Feb 26, 2024

PR that adds Struct to list of valid types in Dask dataframe. Required for a client use case to ingest data with a certain format (documents with nested named attributes)

Copy link
Contributor

@mrchtr mrchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you up for adjusting the integration test as well to test this type?

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobbeSneyders
Copy link
Member

Would you up for adjusting the integration test as well to test this type?

Not sure if this is needed. Since it's also our simple example, I would keep it limited to basic and recommended things.

@philippe-ml6 philippe-ml6 merged commit 6640d88 into main Feb 28, 2024
8 of 9 checks passed
@philippe-ml6 philippe-ml6 deleted the feature/add-struct-type branch February 28, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants