Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows XP support #12

Closed
wants to merge 1 commit into from
Closed

Conversation

jgranick
Copy link
Contributor

I got a report that Windows XP returns an error, saying that shell32 does not include SHCreateItemFromParsingName

This StackOverflow post lists how to make a Windows XP-compatible replacement:

http://stackoverflow.com/questions/20885556/replacement-for-shcreateitemfromparsingname-on-windows-xp/20887104#20887104

I have tried to apply this update in your code style, it appears to be working here. Thanks!

@jgranick
Copy link
Contributor Author

jgranick commented Jan 6, 2016

We have users who have tested OpenFL titles on Windows XP that included file dialogs, and have heard no complaints. This code definitely does work on Windows 7+, where we've tested more regularly on the core team. Thanks!

@mlabbe
Copy link
Owner

mlabbe commented Aug 2, 2016

There is, explicitly, no support for Windows XP in Native File Dialog right now. (See the readme). This is due to the fact that I am not using OpenFileDialog et al., and instead am using a Vista-level API. Some versions of XP support it, and they won't crash, but there is no guarantee.

I would be open to a pull request that implements nfd_win_legacy.cpp which detects the windows version, and calls APIs that are guaranteed to exist on earlier versions of windows. It should be possible to route these at runtime, so every version of windows is served by Native File Dialog without a recompile.

@mlabbe mlabbe closed this Aug 6, 2016
@z64me z64me mentioned this pull request Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants