Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend to a maximum of 256 component types #313

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Conversation

mlange-42
Copy link
Owner

@mlange-42 mlange-42 commented Jan 9, 2024

Rework Mask to hold an array of 4 x uint64 to represent 256 bits. Everything else comes into place by itself.

Alternative to #312:

Primarily avoids All(ids...) either returning a pointer, or requiring users to store the result (temporarily) to be able to get a pointer to it.

Performance remains unchanged, except that MaskFilter matches are about 3 times slower (i.e. filters with component inclusion and exclusion). Not sure why, as the mask functions used there are as fast as before.

@mlange-42 mlange-42 self-assigned this Jan 9, 2024
@mlange-42 mlange-42 added the enhancement New feature or request label Jan 9, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 9, 2024

Pull Request Test Coverage Report for Build 7463696796

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6823343272: 0.0%
Covered Lines: 3835
Relevant Lines: 3835

💛 - Coveralls

@mlange-42 mlange-42 changed the title Extend to a maximum of 256 component types - alternative Extend to a maximum of 256 component types Jan 9, 2024
@mlange-42 mlange-42 marked this pull request as ready for review January 9, 2024 16:35
@mlange-42 mlange-42 merged commit 4c0b1b3 into main Jan 9, 2024
11 checks passed
@mlange-42 mlange-42 deleted the match-mask-pointer branch January 9, 2024 16:38
@mlange-42 mlange-42 added the breaking change Marks API breaking changes label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Marks API breaking changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants