Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix component subscription logic, tweak docs #337

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Fix component subscription logic, tweak docs #337

merged 6 commits into from
Jan 17, 2024

Conversation

mlange-42
Copy link
Owner

@mlange-42 mlange-42 commented Jan 17, 2024 •
edited
Loading

  • use saparate masks for component addition and removal -- was not taken into account correctly
  • fix component subscription logic -- some relation subscriptions could get lost
  • tweak docs of listener implementations

@mlange-42 mlange-42 added the documentation Improvements or additions to documentation label Jan 17, 2024
@mlange-42 mlange-42 self-assigned this Jan 17, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7557475632

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7548759966: 0.0%
Covered Lines: 5225
Relevant Lines: 5225
💛 - Coveralls

@mlange-42 mlange-42 changed the title Refine documentation Fix component subscription logic, tweak docs Jan 17, 2024
@mlange-42 mlange-42 added bug Something isn't working internal internal refactorings labels Jan 17, 2024
@mlange-42 mlange-42 merged commit a7cde98 into main Jan 17, 2024
13 checks passed
@mlange-42 mlange-42 deleted the doc-tweaks branch January 17, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mlange-42 mlange-42

Labels
bug Something isn't working documentation Improvements or additions to documentation internal internal refactorings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlange-42 @coveralls