Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relation events, reset target on relation change, document subscriptions #340

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Fix relation events, reset target on relation change, document subscriptions #340

merged 3 commits into from
Jan 18, 2024

Conversation

mlange-42
Copy link
Owner

@mlange-42 mlange-42 commented Jan 18, 2024 •
edited
Loading

  • Target is reset to zero when (ex)-changing the relation component
  • RelationChanged always triggers TargetChanged
  • Document subscription logic

@mlange-42 mlange-42 added the documentation Improvements or additions to documentation label Jan 18, 2024
@mlange-42 mlange-42 self-assigned this Jan 18, 2024
@mlange-42 mlange-42 changed the title RelationChanged triggers TargetChanged, document subscriptions Fix relation events, reset target on relation change, document subscriptions Jan 18, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7568810352

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7563483577: 0.0%
Covered Lines: 5242
Relevant Lines: 5242
💛 - Coveralls

@mlange-42 mlange-42 added the bug Something isn't working label Jan 18, 2024
@mlange-42 mlange-42 merged commit 5c05233 into main Jan 18, 2024
@mlange-42 mlange-42 deleted the relation-entities-fix branch January 18, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mlange-42 mlange-42

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlange-42 @coveralls