Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dispatch.AddListener #424

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Fix Dispatch.AddListener #424

merged 1 commit into from
Aug 29, 2024

Conversation

g-getsov
Copy link
Contributor

@g-getsov g-getsov commented Aug 27, 2024

I noticed that listeners which were added to an initially empty Dispatch were not being notified. This fixes it.

I noticed that my listeners which were added to an initially empty Dispatch were not being notified. This fixes it.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10582088864

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 99.984%

Files with Coverage Reduction New Missed Lines %
listener/dispatch.go 1 97.62%
Totals Coverage Status
Change from base Build 9845871405: -0.02%
Covered Lines: 6379
Relevant Lines: 6380

💛 - Coveralls

@mlange-42
Copy link
Owner

@g-getsov Many thanks for spotting this bug and taking action!

@mlange-42 mlange-42 merged commit ae3d7cf into mlange-42:main Aug 29, 2024
17 of 18 checks passed
@mlange-42 mlange-42 added the bug Something isn't working label Aug 29, 2024
@g-getsov g-getsov deleted the patch-1 branch August 29, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants