Ensure Assign() copies components before notifying listeners #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
Assign()
, listeners get notified of aComponentAdded
event after theexchange()
happens but before the component gets copied. This means that if that component gets fetched in the listener it will be a "zero" component.The changes in this PR ensure that components are copied before notifying listeners. It splits the internal
exchange()
function intoexchange()
,exchangeNoNotify()
andnotifyExchange()
. This allows us to perform thecopyTo()
in theAssign()
before notifying the listeners.