Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Undo removal optimization #459 #463

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix: Undo removal optimization #459 #463

merged 1 commit into from
Jan 7, 2025

Conversation

mlange-42
Copy link
Owner

@mlange-42 mlange-42 commented Jan 7, 2025

Obviously, #459 was a bit premature. When the un-zeroed memory gets reclaimed, the components of the new or moved entity will take the values of the zombie.

@mlange-42 mlange-42 added the bug Something isn't working label Jan 7, 2025
@mlange-42 mlange-42 self-assigned this Jan 7, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12656507832

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12635930476: 0.0%
Covered Lines: 6518
Relevant Lines: 6518

💛 - Coveralls

@mlange-42 mlange-42 merged commit 964b6b4 into main Jan 7, 2025
19 checks passed
@mlange-42 mlange-42 deleted the undo-remove-opt branch January 7, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants