Settings for gradient/normal thresholds #208
Conversation
|
@SitronX Here's the changes I talked about! Feel free to have a look and let me know if this is useful for you, and if you have any feedback :) Does the "Gradient lighting threshold" setting make sense to you? I had difficulty coming up with a sensible name and description.. I'll plan to start on the Job System task next :) |
|
Hello @mlavik1 Can i just ask why is there this line of code: Also when i looked in shader, in DVR mode, it would be maybe nice if the lightning calculation could be skipped entirely if gradient magnitude is outside of interval, saving quite a bit of performance? Otherwise it looks great, this is great idea and results are looking nice!
Ahh summer cold :D Wish you speedy recovery. |
|
Thanks for the feedback @SitronX !
Yes, it's just using square root scaling for the slider. Without it, it would be hard to modify the lower values, which is where you'll need the most precision. I should probably write some comment 😁 Thanks for pointing it out!
(Update: Removed the job system question I wrote here, and asking in the relevant task instead :D) |
|
Oh, and I forgot to answer this comment:
Good point! Fetching the gradient from the gradient texture is by far the most expensive part of this, but adding an if-check to avoid lighting calculation may still inprove the performance a bit - but from my understanding, doing branching in a shader can have quite a negative impact on performance in some cases, depending on the GPU.. (maybe not so much an issue on modern GPUs?). I'll do some testing though, and see what the effect is :) I'll merge this without it for now though, and then add it if it seems to help. Again, thanks for the feedback! |
|
Hello @mlavik1
Yes you are right about that. When i look again at the lighting code, there is quite a bit of calculations, but nothing extreme. So it will probably not be worth it, because in quite a lot of cases it would do both the branching and calculations, so the benefits would nullify :D |
I think so too! I haven't checked recently, but I'm pretty sure the bottleneck will usually be texture reads (especially when using gradient texture!). So using another format, as you suggested, will likely be a much better optimisation :) |
#175
Gradient visibility threshold + gradient lighting threshold
Gradient lighting threshold
This slider lets you change the minimum and maximum threshold for gradient contribution to lighting.
Voxels with gradient < min will be unlit. Gradient >= max will be fully shaded. Values in between will be partly shaded (for smooth transitions).
Results
Gradient lighting threshold
In isosurface rendering mode, you can now set a minimum gradient magnitude value. Voxels with gradient magnitude less than this will not be rendered.
Results