-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Add support for GPTJ architecture #3012
Conversation
@tlopex Thanks! Do you mind fixing the lint errors as shown in CI? |
@MasterJH5574 Sorry for being late. I thought I solved the lint issue yesterday.
It is the same problem I met in my own device when I did not update |
@tlopex It looks to me that we will need to first send the positional embedding changes to apache/tvm in the file https://github.com/apache/tvm/blob/main/python/tvm/relax/frontend/nn/llm/position_embedding.py. Could you try send your changes to |
@MasterJH5574 Sure, I've already done that. Please take a look at it: apache/tvm#17506 |
@tlopex Hey sorry for the late response. I might have fixed the CI. Could you please help rebase this branch? We can see if it can pass CI now. |
Okay. Thanks! @MasterJH5574 |
I think it can be merged. Thanks so much! |
This PR supports GPTJ architecture.
The model conversation demonstration is here:
I found that I have to change code in
position_embedding
ofrelax
to run locally. I wonder if I still need a update there.