Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompute notebook with PlutoSliderServer #5

Merged
merged 19 commits into from
Jun 20, 2023
Merged

Conversation

sethaxen
Copy link
Member

This PR is an attempt at using JuliaPluto/PlutoSliderServer.jl#29 to prebuild the notebook using PlutoSliderServer, which should allow users to interact with the notebook without them or us needing a Pluto session.

notebooks/supervised_learning.jl Outdated Show resolved Hide resolved
notebooks/supervised_learning.jl Outdated Show resolved Hide resolved
@sethaxen
Copy link
Member Author

This almost completely works! https://mlcolab.github.io/IntroML.jl/previews/PR5/supervised_learning.html

Two remaining issues I'm seeing:

@sethaxen sethaxen marked this pull request as ready for review June 19, 2023 11:58
@sethaxen
Copy link
Member Author

Since the mostly-working precomputed version is strictly better than the completely static version, I'll merge this even with the current issues. A warning has been added to the top that if any interactive elements aren't working correctly, the notebook should be properly run.

@sethaxen sethaxen merged commit 7e2c642 into main Jun 20, 2023
@sethaxen sethaxen deleted the notebookrefresh branch June 20, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant