Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument for selecting alternative normal approximations #78

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

sethaxen
Copy link
Member

@sethaxen sethaxen commented Jun 12, 2022

Implements #15

@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #78 (a55f45d) into main (8e6db0a) will decrease coverage by 0.48%.
The diff coverage is 88.57%.

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   92.89%   92.40%   -0.49%     
==========================================
  Files          13       13              
  Lines         521      527       +6     
==========================================
+ Hits          484      487       +3     
- Misses         37       40       +3     
Impacted Files Coverage Δ
src/multipath.jl 66.66% <ø> (ø)
src/singlepath.jl 85.91% <81.25%> (-3.56%) ⬇️
src/elbo.jl 81.81% <94.73%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6db0a...a55f45d. Read the comment docs.

@sethaxen sethaxen marked this pull request as ready for review June 12, 2022 17:51
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Base: 87.86% // Head: 87.42% // Decreases project coverage by -0.43% ⚠️

Coverage data is based on head (135033f) compared to base (8b3d6c0).
Patch coverage: 88.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   87.86%   87.42%   -0.44%     
==========================================
  Files          13       13              
  Lines         519      525       +6     
==========================================
+ Hits          456      459       +3     
- Misses         63       66       +3     
Impacted Files Coverage Δ
src/multipath.jl 66.66% <ø> (ø)
src/singlepath.jl 86.11% <81.25%> (-3.50%) ⬇️
src/elbo.jl 81.81% <94.73%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants