716 more Hugging Face datasets can be read by mlcroissant. #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Readability improvement: we remove the complex function `last_operations`.
- Correctness: the operation graph has less bugs (see u.a.
"huggingface-c4").
- Performance improvement: we remove a Dijkstra+for-loop (= O(n^2)) for
a hashmap storing the last operations (= O(1)).
Example of dataset that used to timeout and is now usable:
```python
import mlcroissant as mlc
mlc.Dataset("https://datasets-server.huggingface.co/croissant?dataset=gcaillaut/citeseer")
```
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
marcenacp
changed the title
ccl-core
reviewed
Feb 20, 2024
| continue | ||
| return list(operations) | ||
| """Overwrites nx.DiGraph to keep track of last operations. | ||
|
|
There was a problem hiding this comment.
Or "pointer to the chain of last operations"?
ccl-core
reviewed
Feb 20, 2024
| ): | ||
| """Adds all operations for a node of type `Field`. | ||
| """Adds all operations for a node of type `RecordSet`. | ||
|
|
||
| Operations are: | ||
|
|
||
| - `Join` if the field comes from several sources. | ||
| - `ReadFields` to specify how the fields are read. |
There was a problem hiding this comment.
Add Data operation here?
Also, change "if the field" with "if any of the fields related to the recordset"?
There was a problem hiding this comment.
I removed the description because it doesn't bring anything.
ccl-core
approved these changes
Feb 20, 2024
Thanks for the review! This is a refactoring of the existing code, so the current tests still hold. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readability improvement: we remove the function
last_operations.Correctness: the operation graph has less bugs (see u.a. "huggingface-c4" or "coco204-mini"):
O(n^2)) in profit of a hashmap storing the last operations (O(1)).Example of dataset that used to timeout and is now usable:
More than 700 Hugging Face datasets were similarly impacted (see the announcement).
Fixes: #310 and #525.