Add splits to the huggingface-mnist dataset #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
ccl-core
commented
Sep 3, 2024
| @@ -7,18 +7,18 @@ | |||
| from mlcroissant.scripts import load as load_lib | |||
|
|
|||
|
|
|||
| @parametrize_version() | |||
| def test_should_raise_when_no_record_set(version): | |||
| def test_should_raise_when_no_record_set(): | |||
There was a problem hiding this comment.
We could keep the version fixture if we remove the match of the ValueError message. WDYT?
There was a problem hiding this comment.
I'm not sure we have to support 0.8 anymore, so I'm ok with this :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.