Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixture - Token exp #314

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fixture - Token exp #314

merged 2 commits into from
Nov 27, 2024

Conversation

shincap8
Copy link
Contributor

Context

  • The app says a token isn't expire when it actually is.

Changes Made

  1. Multiply the number exp given by the token by 1000 to put it in milliseconds.
  • This would allow the FE to make a good comparison between that number and the actual date.

@shincap8 shincap8 requested a review from a team as a code owner November 21, 2024 20:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@shincap8 shincap8 merged commit 97877ca into main Nov 27, 2024
13 checks passed
@shincap8 shincap8 deleted the Fixture/Token_exp branch November 27, 2024 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remg1997 remg1997 remg1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shincap8 @remg1997