Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loadgen]: Allow one to specify custom CXX_FLAGS by passing the MLPERF_LOADGEN_CXX_FLAGS cmake variable #1140

Merged
merged 5 commits into from
Jun 6, 2022

Conversation

abduld
Copy link
Contributor

@abduld abduld commented Apr 28, 2022

This allows upstream projects to specify extra CXX_FLAGs. For example, one might want to silence specific compiler warnings by passing MLPERF_LOADGEN_CXX_FLAGS="-Wno-unused-parameter" before performing add_subdirectory(inference/loadgen)

@github-actions
Copy link

github-actions bot commented Apr 28, 2022

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@abduld abduld changed the title [loadgen]: Allow one to pass in custom CXX_FLAGS by passing the MLPERF_LOADGEN_CXX_FLAGS cmake variable [loadgen]: Allow one to specify custom CXX_FLAGS by passing the MLPERF_LOADGEN_CXX_FLAGS cmake variable Apr 28, 2022
@tjablin
Copy link
Contributor

tjablin commented Apr 28, 2022

Are you planning to connect MLModelScope to MLPerf Inference?

@abduld
Copy link
Contributor Author

abduld commented Apr 29, 2022

@tjablin . MLModelScope is already connected to MLPerf. See https://github.com/c3sr/mlharness

@nvpohanh
Copy link
Contributor

@abduld Please sign the CLA. If you need help, please reach out to @rnaidu02 @TheKanter . Thanks

@psyhtest
Copy link
Contributor

MLModelScope is already connected to MLPerf. See https://github.com/c3sr/mlharness

Cool! Can we expect to see MLModelScope-powered submissions soon?

@TheKanter
Copy link
Contributor

Hi @abduld https://mlcommons.org/en/get-involved/ has instructions on how to get the CLA signed at the bottom of the page. Sorry about the CLA bot, it's out of date.

@abduld
Copy link
Contributor Author

abduld commented May 2, 2022

Thanks @TheKanter and @nvpohanh , I have submitted the CLA

…F_LOADGEN_CXX_FLAGS cmake variable. This allows upstream projects to specify extra CXX_FLAGs.
@abduld abduld force-pushed the loadgen-cxx-opts branch from 933765f to b415995 Compare May 3, 2022 23:18
@abduld abduld requested a review from nvpohanh May 4, 2022 19:17
Copy link
Contributor

@nvpohanh nvpohanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. @rnaidu02 please bring this up in the WG. thanks

@abduld
Copy link
Contributor Author

abduld commented May 24, 2022

approved. @rnaidu02 please bring this up in the WG. thanks

Thanks @nvpohanh , how can I merge this?

@nvpohanh
Copy link
Contributor

@abduld Could you bring this up in the WG meeting? @rnaidu02 for visibility

@nv-ananjappa
Copy link
Contributor

@abduld Could you rebase this to base branch?

@abduld
Copy link
Contributor Author

abduld commented May 26, 2022

@abduld Could you rebase this to base branch?

done

@tjablin tjablin merged commit 1483c8f into mlcommons:master Jun 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants