-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loadgen]: Allow one to specify custom CXX_FLAGS by passing the MLPERF_LOADGEN_CXX_FLAGS cmake variable #1140
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Are you planning to connect MLModelScope to MLPerf Inference? |
@tjablin . MLModelScope is already connected to MLPerf. See https://github.com/c3sr/mlharness |
@abduld Please sign the CLA. If you need help, please reach out to @rnaidu02 @TheKanter . Thanks |
Cool! Can we expect to see MLModelScope-powered submissions soon? |
Hi @abduld https://mlcommons.org/en/get-involved/ has instructions on how to get the CLA signed at the bottom of the page. Sorry about the CLA bot, it's out of date. |
Thanks @TheKanter and @nvpohanh , I have submitted the CLA |
…F_LOADGEN_CXX_FLAGS cmake variable. This allows upstream projects to specify extra CXX_FLAGs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. @rnaidu02 please bring this up in the WG. thanks
@abduld Could you rebase this to base branch? |
done |
This allows upstream projects to specify extra CXX_FLAGs. For example, one might want to silence specific compiler warnings by passing
MLPERF_LOADGEN_CXX_FLAGS="-Wno-unused-parameter"
before performingadd_subdirectory(inference/loadgen)