Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PerformanceResult/Summary to results.h/cc #1192

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Move PerformanceResult/Summary to results.h/cc #1192

merged 4 commits into from
Oct 18, 2022

Conversation

saar-eliad
Copy link
Contributor

Fixing an existing TODO in code.

@github-actions
Copy link

github-actions bot commented Jul 26, 2022

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@nv-ananjappa
Copy link
Contributor

LGTM. But we should not merge this to v2.1 branch because submitters are collecting submission logs already with that branch.

@saar-eliad saar-eliad changed the title Move PerformanceResult/Summary to results.h/cc [WIP]Move PerformanceResult/Summary to results.h/cc Jul 27, 2022
@saar-eliad saar-eliad changed the title [WIP]Move PerformanceResult/Summary to results.h/cc Move PerformanceResult/Summary to results.h/cc Jul 27, 2022
Copy link
Contributor

@arjunsuresh arjunsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful change. LGTM

@saar-eliad
Copy link
Contributor Author

@nv-ananjappa please merge?

@rnaidu02 rnaidu02 merged commit 161b745 into mlcommons:master Oct 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants