Remove const in QSL #1199
Merged
Remove const in QSL #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
psyhtest
approved these changes
Jul 29, 2022
|
@pgmpablo157321 Will this PR address all the changes mentioned in PR#1193 by Jinho? |
|
@rnaidu02 To my understanding, Jinho is fine with the status quo and with this changes. This PR makes the changes discussed here is that right @nv-jinhosuh? |
|
That is right @pgmpablo157321 and @rnaidu02 . I am fine either way - both SUT/QSL-Name() being non-const (this PR being merged), or only SUT->Name() being non-const (already in 2.1 repo). Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1193
Implements this change
If this PR is merged, submitters should be allowed to build from this or the previous commit