Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github test for loadgen #1278

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Added Github test for loadgen #1278

merged 4 commits into from
Nov 8, 2022

Conversation

arjunsuresh
Copy link
Contributor

This test will ensure that PRs won't break loadgen.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@pgmpablo157321 pgmpablo157321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


on:
pull_request:
branches: [ "master", "dev" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a dev branch? or do we plan to have one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pgmpablo157321 for reviewing. I think we'll need a dev branch as we are going to use the master branch for submission. So, from the code freeze stage until submission we'll need to use a dev branch.

@rnaidu02 rnaidu02 merged commit 0b18682 into mlcommons:master Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants