Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply min_new_tokens=2 to mixtral-8x7b, address #1777 #1884

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

nvzhihanj
Copy link
Contributor

@nvzhihanj nvzhihanj commented Oct 22, 2024

@pgmpablo157321 @mrmhodak to review. Please also help upload the dataset pickle file (sent in google chat) so I can replace the old link. Address #1777

@nvzhihanj nvzhihanj requested a review from a team as a code owner October 22, 2024 03:38
Copy link

github-actions bot commented Oct 22, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@nvzhihanj
Copy link
Contributor Author

@pgmpablo157321 the code formatter hook seems to be broken. Can you help take a look?

[fix/nv-zhihanj-1777-mixtral 8cf2536] [Automated Commit] Format Codebase
 3 files changed, 135 insertions(+), 80 deletions(-)
remote: Permission to mlcommons/inference.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/mlcommons/inference.git/': The requested URL returned error: 403
Error: Process completed with exit code 128.

@arjunsuresh
Copy link
Contributor

arjunsuresh commented Oct 22, 2024

Hi @nvzhihanj This PR should fix the code format github action.

@nvzhihanj nvzhihanj force-pushed the fix/nv-zhihanj-1777-mixtral branch from d991a9b to 13d1c09 Compare October 22, 2024 17:23
@mrmhodak mrmhodak merged commit f74d16f into mlcommons:master Oct 22, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants