feat: pass task-specific config to backend #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anhappdev
commented
Sep 24, 2024
anhappdev
commented
- Closes make the number of steps of stable diffusion configuration #921
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
anhappdev
commented
Sep 24, 2024
Comment on lines
+250
to
+257
| custom_config { | ||
| id: "stable_diffusion_seed" | ||
| value: "633994880" | ||
| } | ||
| custom_config { | ||
| id: "stable_diffusion_num_steps" | ||
| value: "20" | ||
| } |
There was a problem hiding this comment.
This how a custom setting for all backends can be defined in tasks.pbtxt
anhappdev
commented
Sep 24, 2024
Comment on lines
+67
to
+75
| for (int i = 0; i < configs->count; ++i) { | ||
| if (strcmp(configs->keys[i], "stable_diffusion_seed") == 0) { | ||
| backend_data->seed = atoi(configs->values[i]); | ||
| } | ||
| if (strcmp(configs->keys[i], "stable_diffusion_num_steps") == 0) { | ||
| backend_data->num_steps = atoi(configs->values[i]); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
The backend can read them from mlperf_backend_configuration_t in mlperf_backend_create.
anhappdev
commented
Sep 24, 2024
| --lib_path="bazel-bin/mobile_back_tflite/cpp/backend_tflite/libtflitebackend.so" \ | ||
| --custom_config="stable_diffusion_num_steps:20,stable_diffusion_seed:633994880" \ |
There was a problem hiding this comment.
Using the main.cc file for development, one can pass it with the flag custom_config
|
anhappdev
changed the title
freedomtan
approved these changes
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.