Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call the HuggingFace token a token consistently #466

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

rogthefrog
Copy link
Contributor

The HuggingFace token was referred to as api_key in some places. This PR makes the naming consistent.

Together with that change, the token/key secret classes are moved out of the client code that uses them and into their own modules, so they can be imported into client code and tests and other modules.

@rogthefrog rogthefrog requested a review from a team as a code owner September 20, 2024 02:45
Copy link

github-actions bot commented Sep 20, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, much tidier. Thanks!

@rogthefrog rogthefrog merged commit e280c71 into main Sep 20, 2024
4 checks passed
@rogthefrog rogthefrog deleted the feat/459/huggingface_secrets branch September 20, 2024 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants