Enable SolrCloud and Cleanup #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niquerio
force-pushed
the
make-author-and-subject-independent
branch
from
6ad7a1c
to
b6c659e
Compare
niquerio
force-pushed
the
make-author-and-subject-independent
branch
from
c1506c0
to
54d2345
Compare
niquerio
changed the title
erinesullivan
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the code for enabling use of SolrCloud collections. At first it enabled being able to use them independently. Now that all of the SolrCloud collections are working there is one toggle for either all Solrcloud or all legacy solr.
This PR introduces the use of the Services object which enables access to environment variables by doing
S.my_variableinstead ofENV.fetch["MY_VARIABLE"]. This allows for more nuance in setting up environments and makes the code more readable.Also changing from the word
callnumbertocall_numberas much as possible since they are two words.