Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

September 2023 dependency updates. #98

Merged
merged 5 commits into from
Sep 11, 2023
Merged

September 2023 dependency updates. #98

merged 5 commits into from
Sep 11, 2023

Conversation

erinesullivan
Copy link
Collaborator

@erinesullivan erinesullivan commented Sep 5, 2023

Overview

Monthly dependency update to help maintain Catalog Browse.

NPM

These dependencies have been updated to their latest versions:

  • postcss

Ruby

These dependencies have been updated to their latest versions:

  • anyway_config
  • minitest
  • rubocop
  • standard
  • webmock

Dockerfile

Nodejs changed deprecated the installation script setup_XX.x. The Dockerfile reflects the current recommended way to install node. It also updates nodejs to 20.

Environment Variables

Turned off the feature gates for author and subject browses
Renamed CATALOG_SOLR to BROWSE_SOLR
Renamed CALLNUMBERS_CORE to CALLNUMBER_CORE
Renamed AUTHORS_CORE to AUTHORITY_CORE

Testing

  • Install the updated packages (docker-compose run --rm web npm install).
  • Make a CSS change, and build the styles (docker-compose run --rm web npm run build).
  • Start the site to see if your change was made, and everything still works (docker-compose up).
  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge

@erinesullivan erinesullivan added the dependencies Changes to packages or gems. label Sep 5, 2023
@erinesullivan erinesullivan self-assigned this Sep 5, 2023
Copy link
Collaborator

@niquerio niquerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in the testing environment including all of the environment variable changes. Should be good to go.

🚢

@niquerio niquerio merged commit 3ccb6b3 into main Sep 11, 2023
1 check passed
@erinesullivan erinesullivan deleted the 2023-09-05-updates branch February 13, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to packages or gems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants