Merge pull request #99 from mlibrary/floor-location-fix

Floor location fix
mlibrary · Oct 14, 2024 · 349b0da · 349b0da
2 parents b0dcaee + 01211cb
commit 349b0da
Show file tree

Hide file tree

Showing 4 changed files with 592 additions and 33 deletions.
diff --git a/umich_catalog_indexing/lib/jobs/translation_map_generator/floor_locations.rb b/umich_catalog_indexing/lib/jobs/translation_map_generator/floor_locations.rb
@@ -19,7 +19,7 @@ def file_path
 
         # @returns [String] YAML string of translation map
         def generate
-          fetch.to_json
+          JSON.pretty_generate fetch
         end
 
         def fetch
@@ -65,11 +65,7 @@ def start
           cn = @call_number_range[0]
           return cn.to_f if type == "Dewey"
 
-          if _music_match?(cn)
-            cn = _music_call_number(cn)
-          elsif _asia_match?(cn)
-            cn = _asia_call_number(cn)
-          elsif _number_ending?(cn)
+          if _number_ending?(cn)
             cn = _number_ending_call_number(cn)
           end
           cn.gsub(/\s+/, "")
@@ -81,11 +77,7 @@ def stop
           cn = @call_number_range[1] || @call_number_range[0]
           return (cn + ".9999").to_f if type == "Dewey"
 
-          if _music_match?(cn)
-            cn = _music_call_number(cn)
-          elsif _asia_match?(cn)
-            cn = _asia_call_number(cn)
-          elsif _number_ending?(cn)
+          if _number_ending?(cn)
             cn = _number_ending_call_number(cn)
           end
 
@@ -118,30 +110,21 @@ def _clean_call_number_range(str)
           str.downcase.split(/\s+-\s+/).map { |x| x.strip }
         end
 
-        def _music_match?(cn)
-          library == "MUSIC" && cn.match?(/^m/)
-        end
-
-        def _music_call_number(cn)
-          parts = cn.split(/\s+/)
-          "#{parts[0]}000#{parts[1]}.00000#{parts[2]}"
-        end
-
-        def _asia_match?(cn)
-          location == "ASIA" && cn.match?(".")
-        end
-
-        def _asia_call_number(cn)
-          parts = cn.split(/\s+/)
-          "#{parts[0]}0#{parts[1]}000"
-        end
-
         def _number_ending?(cn)
           cn.match?(/\d$/)
         end
 
         def _number_ending_call_number(cn)
-          cn + ".00000"
+          parts = cn.split(/\s+/)
+          letters = parts[0]
+
+          numbers = parts[1].split(".")
+          integer_part = numbers[0] || "0"
+          fractional_part = numbers[1] || "0"
+
+          rest = parts[2]
+
+          "#{letters}#{integer_part.rjust(4,'0')}.#{fractional_part.ljust(5,'0')}#{parts[2]}"
         end
       end
     end